[BF] new try

Zway-Bot/Moduls/AModul.cs

@@ -6,7 +6,7 @@ using BlubbFish.Utils;
 namespace ZwayBot {
   abstract class AModul {
     protected ZwayController zw;
-    private InIReader settings;
+    private readonly InIReader settings;
     protected Dictionary<String, Dictionary<String, String>> config = new Dictionary<String, Dictionary<String, String>>();
 
     public Boolean HasConfig { get; private set; }

Zway-Bot/Moduls/CronJob.cs

@@ -16,7 +16,7 @@ namespace ZwayBot.Moduls {
 
     public override event ModulEvent Update;
 
-    private Dictionary<String, String> cron_named = new Dictionary<String, String> {
+    private readonly Dictionary<String, String> cron_named = new Dictionary<String, String> {
       { "@yearly",   "0 0 1 1 *" },
       { "@annually", "0 0 1 1 *" },
       { "@monthly",  "0 0 1 * *" },
@@ -166,19 +166,13 @@ namespace ZwayBot.Moduls {
       if (!this.disposedValue) {
         if (disposing) {
           this.thread.Abort();
-          while(this.thread.ThreadState != ThreadState.Aborted) { Thread.Sleep(100); }
+          while(this.thread.ThreadState == ThreadState.Running) { Thread.Sleep(100); }
         }
-
         this.thread = null;
-
         this.disposedValue = true;
       }
     }
 
-    ~CronJob() {
-      Dispose(false);
-    }
-
     public override void Dispose() {
       Dispose(true);
       GC.SuppressFinalize(this);

Zway-Bot/Moduls/Mqtt.cs

@@ -11,7 +11,7 @@ using LitJson;
 
 namespace ZwayBot.Moduls {
   class Mqtt : AModul, IDisposable {
-    private ABackend mqtt;
+    private readonly ABackend mqtt;
     private Dictionary<String, AModul> modules;
 
     public override event ModulEvent Update;

Zway-Bot/Moduls/Overtaker.cs

@@ -7,7 +7,7 @@ using BlubbFish.Utils;
 
 namespace ZwayBot.Moduls {
   internal class Overtaker : AModul, IDisposable {
-    private Dictionary<String, Dictionary<String, String>> events = new Dictionary<String, Dictionary<String, String>>();
+    private readonly Dictionary<String, Dictionary<String, String>> events = new Dictionary<String, Dictionary<String, String>>();
 
     public override event ModulEvent Update;
 
@@ -89,10 +89,6 @@ namespace ZwayBot.Moduls {
       }
     }
 
-    ~Overtaker() {
-      Dispose(false);
-    }
-
     public override void Dispose() {
       Dispose(true);
       GC.SuppressFinalize(this);

Zway-Bot/Moduls/Senml.cs

@@ -9,8 +9,8 @@ using BlubbFish.Utils.IoT.Interfaces;
 namespace ZwayBot.Moduls {
   class Senml : AModul {
     public override event ModulEvent Update;
-    private ABackend mqtt;
+    private readonly ABackend mqtt;
-    private String SenmlGuid;
+    private readonly String SenmlGuid;
 
     public Senml(ZwayController zway, InIReader settings) : base(zway, settings) {
       if (this.config.ContainsKey("settings")) {

Zway-Bot/Program.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Reflection;
+using System.Threading;
 using BlubbFish.IoT.Zway;
 using BlubbFish.Utils;
 
@@ -11,7 +12,7 @@ namespace ZwayBot {
     private readonly ZwayController zw;
     private readonly Dictionary<String, AModul> moduls = new Dictionary<String, AModul>();
     private Boolean RunningProcess = true;
-    private System.Threading.Thread sig_thread;
+    private Thread sig_thread;
     private readonly ProgramLogger logger = new ProgramLogger();
 
     public Program(String[] args) {
@@ -44,27 +45,32 @@ namespace ZwayBot {
 
     private void WaitForShutdown() {
       if (Type.GetType("Mono.Runtime") != null) {
-        this.sig_thread = new System.Threading.Thread(delegate () {
+        this.sig_thread = new Thread(delegate () {
           Mono.Unix.UnixSignal[] signals = new Mono.Unix.UnixSignal[] {
             new Mono.Unix.UnixSignal(Mono.Unix.Native.Signum.SIGTERM),
             new Mono.Unix.UnixSignal(Mono.Unix.Native.Signum.SIGINT)
           };
-          while (this.RunningProcess) {
+          Console.WriteLine("Signalhandler Mono attached.");
+          while (true) {
             Int32 i = Mono.Unix.UnixSignal.WaitAny(signals, -1);
-            this.RunningProcess = false;
+            Console.WriteLine("Signalhandler Mono INT recieved " + i + ".");
+            this.RunningProcess = false; // TODO BUG
+            break;
           }
         });
         this.sig_thread.Start();
       } else {
         Console.CancelKeyPress += new ConsoleCancelEventHandler(this.SetupShutdown);
+        Console.WriteLine("Signalhandler Windows attached.");
       }
       while (this.RunningProcess) {
-        System.Threading.Thread.Sleep(100);
+        Thread.Sleep(100);
       }
     }
 
     private void SetupShutdown(Object sender, ConsoleCancelEventArgs e) {
       e.Cancel = true;
+      Console.WriteLine("Signalhandler Windows INT recieved.");
       this.RunningProcess = false;
     }
 

Zway-Bot/Properties/AssemblyInfo.cs

@@ -31,8 +31,8 @@ using System.Runtime.InteropServices;
 // Sie können alle Werte angeben oder Standardwerte für die Build- und Revisionsnummern verwenden,
 // übernehmen, indem Sie "*" eingeben:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.5.0")]
+[assembly: AssemblyVersion("1.5.6")]
-[assembly: AssemblyFileVersion("1.5.0")]
+[assembly: AssemblyFileVersion("1.5.6")]
 [assembly: NeutralResourcesLanguage("de-DE")]
 
 // “Internet Of Things” icon by By Michael Wohlwend, US, from thenounproject.com.

Zway-Bot/Zway-Bot.csproj

@@ -125,6 +125,7 @@
     <None Include="dpkg\create-Builds.bat" />
     <None Include="dpkg\make-deb.sh" />
     <None Include="dpkg\prerm" />
+    <None Include="dpkg\zwaybot-logrotate" />
     <None Include="dpkg\zwaybot.service" />
     <None Include="packages.config" />
     <None Include="Resources\Icon.ico" />

Zway-Bot/dpkg/make-deb.sh

@@ -3,9 +3,12 @@
 HOMEDIR="/home/blubb"
 ROOT="$HOMEDIR/deb"
 OUTPUT="../bin/Release"
+
 EXEC="$ROOT/usr/local/bin/zwaybot"
 CONFIG="$ROOT/etc/zwaybot"
 SYSTEMD="$ROOT/etc/systemd/system"
+LOGROTATE="$ROOT/etc/logrotate.d"
+
 DEBIAN="$ROOT/DEBIAN"
 VMAJOR=$(grep -e "^\[assembly: AssemblyVersion(\"" ../Properties/AssemblyInfo.cs | cut -d'"' -f 2 | cut -d'.' -f 1)
 VMINOR=$(grep -e "^\[assembly: AssemblyVersion(\"" ../Properties/AssemblyInfo.cs | cut -d'"' -f 2 | cut -d'.' -f 2)
@@ -16,6 +19,7 @@ mkdir -p $EXEC
 mkdir -p $CONFIG
 mkdir -p $DEBIAN
 mkdir -p $SYSTEMD
+mkdir -p $LOGROTATE
 
 cp control $DEBIAN
 cp preinst $DEBIAN
@@ -37,6 +41,9 @@ cp $OUTPUT/config-example/* $CONFIG
 chmod 644 $CONFIG/*
 chmod 755 $CONFIG
 
+cp zwaybot-logrotate $LOGROTATE/zwaybot
+chmod 644 $LOGROTATE/*
+
 dpkg-deb --build $ROOT
-mv $HOMEDIR/deb.deb ../../../Builds/$ARCHT/"zwaybot_$VMAJOR.$VMINOR-$VBUILD.deb"
+mv $HOMEDIR/deb.deb ../../../Builds/"$ARCHT-zwaybot_$VMAJOR.$VMINOR-$VBUILD.deb"
 rm $HOMEDIR/deb -r

Zway-Bot/dpkg/postinst

@@ -1,4 +1,7 @@
-#!/bin/sh
+#!/bin/bash
 
 systemctl daemon-reload
-service zwaybot start
+if [[ $(systemctl is-active zwaybot || true) == "active" ]]
+then
+        service zwaybot restart
+fi

Zway-Bot/dpkg/preinst

@@ -1,6 +1,5 @@
-#!/bin/sh
+#!/bin/bash
 
-service zwaybot stop
 useradd -M zwaybot
 usermod -L zwaybot
 groupadd zwaybot

Zway-Bot/dpkg/zwaybot-logrotate

@@ -0,0 +1,10 @@
+/var/log/zwaybot.log {
+	compress
+	copytruncate
+	daily
+	delaycompress
+	missingok
+	notifempty
+	rotate 4
+	size=10M
+}

Zway-Bot/dpkg/zwaybot.service

@@ -8,10 +8,12 @@ After=network-online.target
 User=zwaybot
 Group=zwaybot
 WorkingDirectory=/usr/local/bin/zwaybot
-ExecStartPre=rm /var/log/zwaybot.log && touch /var/log/zwaybot.log && chown zwaybot:zwaybot /var/log/zwaybot.log && chmod 644 /var/log/zwaybot.log
+# ExecStartPre=/bin/rm /var/log/zwaybot.log && /bin/touch /var/log/zwaybot.log && /bin/chown zwaybot:zwaybot /var/log/zwaybot.log && /bin/chmod 644 /var/log/zwaybot.log
 ExecStart=/usr/bin/mono /usr/local/bin/zwaybot/Zway-Bot.exe
 KillMode=control-group
 Restart=on-failure
+StandardOutput=null
+StandardError=syslog+journal
 
 [Install]
 WantedBy=multi-user.target