[1.2.6] Makeing Logging easyier

Bot-Utils/ABot.cs

@@ -1,71 +1,58 @@
 using System;
+using System.Collections.Generic;
+using System.Reflection;
 using System.Runtime.Loader;
 using System.Threading;
 
 namespace BlubbFish.Utils.IoT.Bots {
   public abstract class ABot {
-    #if !NETCOREAPP
-    private Thread sig_thread;
-    #endif
     private Boolean RunningProcess = true;
+    private readonly ProgramLogger logger = null;
 
-    protected ProgramLogger logger = new ProgramLogger();
+    public Boolean DebugLogging {
+      get;
+    }
 
-    private void SetupShutdown(Object sender, ConsoleCancelEventArgs e) {
+    public ABot(String[] _, Boolean fileLogging, String configSearchPath) {
+      InIReader.SetSearchPath(new List<String>() { "/etc/"+ configSearchPath, Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData) + "\\"+ configSearchPath });
+      if(fileLogging) {
+        this.logger = new ProgramLogger(InIReader.GetInstance("settings").GetValue("logging", "path", Assembly.GetEntryAssembly().GetName().Name + ".log"));
+      }
+      if(Boolean.TryParse(InIReader.GetInstance("settings").GetValue("logging", "debug", "true"), out Boolean debuglog)) {
+        this.DebugLogging = debuglog;
+      }
+    }
+
+    private void ConsoleCancelEvent(Object sender, ConsoleCancelEventArgs e) {
       e.Cancel = true;
-      Console.WriteLine("BlubbFish.Utils.IoT.Bots.Bot.SetupShutdown: Signalhandler Windows INT recieved.");
+      Console.WriteLine("BlubbFish.Utils.IoT.Bots.Bot.ConsoleCancelEvent()");
       this.RunningProcess = false;
     }
 
     #if NETCOREAPP
-    private void Default_Unloading(AssemblyLoadContext obj) {
-      Console.WriteLine("BlubbFish.Utils.IoT.Bots.Bot.SetupShutdown: Signalhandler Windows NETCORE recieved.");
-      this.RunningProcess = false;
-      Console.WriteLine("BlubbFish.Utils.IoT.Bots.Bot.WaitForShutdown: Shutdown.");
-      this.Dispose(); 
-    }
+    private void Unloading(AssemblyLoadContext obj) => this.RunningProcess = false;
+
+    private void ProcessExit(Object sender, EventArgs e) => this.RunningProcess = false;
     #endif
 
     protected void WaitForShutdown() {
-      if(Type.GetType("Mono.Runtime") != null) {
-        #if !NETCOREAPP
-        this.sig_thread = new Thread(delegate () {
-          Mono.Unix.UnixSignal[] signals = new Mono.Unix.UnixSignal[] {
-            new Mono.Unix.UnixSignal(Mono.Unix.Native.Signum.SIGTERM),
-            new Mono.Unix.UnixSignal(Mono.Unix.Native.Signum.SIGINT)
-          };
-          Console.WriteLine("BlubbFish.Utils.IoT.Bots.Bot.WaitForShutdown: Signalhandler Mono attached.");
-          while(true) {
-            Int32 i = Mono.Unix.UnixSignal.WaitAny(signals, -1);
-            Console.WriteLine("BlubbFish.Utils.IoT.Bots.Bot.WaitForShutdown: Signalhandler Mono INT recieved " + i + ".");
-            this.RunningProcess = false;
-            break;
-          }
-        });
-        this.sig_thread.Start();
-        #endif
-      } else {
-        #if NETCOREAPP
-        AssemblyLoadContext.Default.Unloading += this.Default_Unloading;
-        Console.WriteLine("BlubbFish.Utils.IoT.Bots.Bot.WaitForShutdown: Signalhandler Netcore attached.");
-        #endif
-        Console.CancelKeyPress += new ConsoleCancelEventHandler(this.SetupShutdown);
-        Console.WriteLine("BlubbFish.Utils.IoT.Bots.Bot.WaitForShutdown: Signalhandler Windows attached.");
-      }
+      #if NETCOREAPP
+      AssemblyLoadContext.Default.Unloading += this.Unloading;
+      AppDomain.CurrentDomain.ProcessExit += this.ProcessExit;
+      Console.WriteLine("BlubbFish.Utils.IoT.Bots.Bot.WaitForShutdown: Attach Unloading and ProcessExit.");
+      #endif
+      Console.CancelKeyPress += new ConsoleCancelEventHandler(this.ConsoleCancelEvent);
+      Console.WriteLine("BlubbFish.Utils.IoT.Bots.Bot.WaitForShutdown: Attach ConsoleCancelEvent.");
       while(this.RunningProcess) {
         Thread.Sleep(100);
       }
       Console.WriteLine("BlubbFish.Utils.IoT.Bots.Bot.WaitForShutdown: Shutdown.");
     }
 
-    
-
     public virtual void Dispose() {
-      #if !NETCOREAPP
-      if(this.sig_thread != null && this.sig_thread.IsAlive) {
-        this.sig_thread.Abort();
-      }
-      #endif
+      Console.WriteLine("BlubbFish.Utils.IoT.Bots.Bot.Dispose: Shutdown.");
+      this.RunningProcess = false;
+      this.logger?.Dispose();
     }
   }
 }

Bot-Utils/AWebserver.cs

@@ -12,7 +12,7 @@ namespace BlubbFish.Utils.IoT.Bots {
     
     protected HttpListener httplistener;
 
-    public AWebserver(Dictionary<String, String> settings) => this.config = settings;
+    public AWebserver(String[] args, Boolean fileLogging, String configSearchPath, Dictionary<String, String> settings) : base(args, fileLogging, configSearchPath) => this.config = settings;
 
     protected void StartListen() {
       this.httplistener = new HttpListener();

Bot-Utils/AWebserverDataBackend.cs

@@ -7,7 +7,7 @@ using BlubbFish.Utils.IoT.Events;
 namespace BlubbFish.Utils.IoT.Bots {
   public abstract class AWebserverDataBackend : AWebserver {
     protected ABackend databackend;
-    protected AWebserverDataBackend(ABackend backend, Dictionary<String, String> settings) : base(settings) => this.databackend = backend;
+    protected AWebserverDataBackend(String[] args, Boolean fileLogging, String configSearchPath, ABackend backend, Dictionary<String, String> settings) : base(args, fileLogging, configSearchPath, settings) => this.databackend = backend;
 
     protected void StartDataBackend() => this.databackend.MessageIncomming += this.Backend_MessageIncomming;
 

Bot-Utils/Bot-Utils.csproj

@@ -5,17 +5,19 @@
     <RootNamespace>BlubbFish.Utils.IoT.Bots</RootNamespace>
     <AssemblyName>Bot-Utils</AssemblyName>
     <PackageId>Bots.IoT.Utils.BlubbFish</PackageId>
-    <Version>1.2.4</Version>
+    <Version>1.2.6</Version>
     <NeutralLanguage>de-DE</NeutralLanguage>
     <Description>Bot-Utils are helpers for programming a bot</Description>
     <Authors>BlubbFish</Authors>
     <Company>BlubbFish</Company>
-    <Copyright>Copyright © BlubbFish 2018 - 18.01.2022</Copyright>
+    <Copyright>Copyright © BlubbFish 2018 - 25.01.2022</Copyright>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
     <PackageProjectUrl>http://git.blubbfish.net/vs_utils/Bot-Utils</PackageProjectUrl>
     <RepositoryUrl>http://git.blubbfish.net/vs_utils/Bot-Utils.git</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
     <PackageReleaseNotes>
+      1.2.6 - 2022-01-25 - Makeing Logging easyier
+      1.2.5 - 2022-01-20 - Better linux handling
       1.2.4 - 2022-01-18 - Config enabled module loading
       1.2.3 - 2022-01-09 - Tiny Refactoring
       1.2.2 - 2021-08-22 - Going to netcore

Bot-Utils/Bot.cs

@@ -9,8 +9,11 @@ namespace BlubbFish.Utils.IoT.Bots {
   public abstract class Bot<T> : ABot {
     protected readonly Dictionary<String, AModul<T>> moduls = new Dictionary<String, AModul<T>>();
 
+    public Bot(String[] args, Boolean fileLogging, String configSearchPath) : base(args, fileLogging, configSearchPath) { }
+
     protected void ModulDispose() {
       foreach (KeyValuePair<String, AModul<T>> item in this.moduls) {
+        Console.WriteLine("BlubbFish.Utils.IoT.Bots.Bot.ModulDispose: Entlade Modul: " + item.Key);
         item.Value.Dispose();
         Console.WriteLine("BlubbFish.Utils.IoT.Bots.Bot.ModulDispose: Modul entladen: " + item.Key);
       }
@@ -60,6 +63,10 @@ namespace BlubbFish.Utils.IoT.Bots {
       }
     }
 
-    protected void ModulUpdate(Object sender, ModulEventArgs e) => Console.WriteLine(e.ToString());
+    protected void ModulUpdate(Object sender, ModulEventArgs e) {
+      if(this.DebugLogging) {
+        Console.WriteLine(e.ToString());
+      }
+    }
   }
 }

Bot-Utils/Moduls/CronJob.cs

@@ -3,12 +3,14 @@ using System.Collections.Generic;
 using System.Globalization;
 using System.Text.RegularExpressions;
 using System.Threading;
+
 using BlubbFish.Utils.IoT.Bots.Interfaces;
 
 namespace BlubbFish.Utils.IoT.Bots.Moduls {
-  public abstract class CronJob<T> : AModul<T>, IDisposable, IForceLoad {
+  public abstract class CronJob<T> : AModul<T>, IForceLoad {
     protected readonly List<Tuple<String, Action<Object>, Object>> internalCron = new List<Tuple<String, Action<Object>, Object>>();
     protected Thread thread;
+    protected Boolean threadRunning = false;
     protected DateTime crontime;
 
     protected readonly Dictionary<String, String> cron_named = new Dictionary<String, String> {
@@ -24,14 +26,18 @@ namespace BlubbFish.Utils.IoT.Bots.Moduls {
     public CronJob(T lib, InIReader settings) : base(lib, settings) {
       this.crontime = DateTime.Now;
       this.thread = new Thread(this.Runner);
+      this.threadRunning = true;
       this.thread.Start();
     }
     #endregion
 
     #region Cronjobrunner
     protected void Runner() {
-      Thread.Sleep(DateTime.Now.AddMinutes(1).AddSeconds(DateTime.Now.Second * -1).AddMilliseconds(DateTime.Now.Millisecond * -1) - DateTime.Now);
-      while (true) {
+      DateTime nextminute = DateTime.Now.AddMinutes(1).AddSeconds(DateTime.Now.Second * -1).AddMilliseconds(DateTime.Now.Millisecond * -1);
+      while(nextminute > DateTime.Now && this.threadRunning) {
+        Thread.Sleep(100);
+      }
+      while (this.threadRunning) {
         if (this.crontime.Minute != DateTime.Now.Minute) {
           this.crontime = DateTime.Now;
           if (this.config.Count != 0) {
@@ -143,27 +149,13 @@ namespace BlubbFish.Utils.IoT.Bots.Moduls {
     public override void SetInterconnection(String cron, Action<Object> hook, Object data) => this.internalCron.Add(new Tuple<String, Action<Object>, Object>(cron, hook, data));
 
     protected override void UpdateConfig() { }
-    #endregion
-
-    #region IDisposable Support
-    private Boolean disposedValue = false;
-
-    protected virtual void Dispose(Boolean disposing) {
-      if (!this.disposedValue) {
-        if (disposing) {
-          if (this.thread != null) {
-            this.thread.Abort();
-            while (this.thread.ThreadState == ThreadState.Running) { Thread.Sleep(100); }
-          }
-        }
-        this.thread = null;
-        this.disposedValue = true;
-      }
-    }
 
     public override void Dispose() {
-      this.Dispose(true);
-      GC.SuppressFinalize(this);
+      this.threadRunning = false;
+      while(this.thread != null && this.thread.IsAlive) {
+        Thread.Sleep(10);
+      }
+      this.thread = null;
     }
     #endregion
   }

Bot-Utils/Moduls/Mqtt.cs

@@ -7,7 +7,7 @@ using BlubbFish.Utils.IoT.Events;
 using LitJson;
 
 namespace BlubbFish.Utils.IoT.Bots.Moduls {
-  public abstract class Mqtt<T> : AModul<T>, IDisposable {
+  public abstract class Mqtt<T> : AModul<T> {
     protected ABackend mqtt;
     protected Dictionary<String, AModul<T>> modules;
 
@@ -34,6 +34,8 @@ namespace BlubbFish.Utils.IoT.Bots.Moduls {
     public override void Interconnect(Dictionary<String, AModul<T>> moduls) => this.modules = moduls;
 
     protected override void UpdateConfig() => this.Reconnect();
+
+    public override void Dispose() => this.Disconnect();
     #endregion
 
     protected Tuple<Boolean, MqttEvent> ChangeConfig(BackendEvent e, String topic) {
@@ -74,23 +76,5 @@ namespace BlubbFish.Utils.IoT.Bots.Moduls {
       }
       return new Tuple<Boolean, MqttEvent>(false, null);
     }
-
-    #region IDisposable Support
-    private Boolean disposedValue = false;
-
-    protected void Dispose(Boolean disposing) {
-      if (!this.disposedValue) {
-        if (disposing) {
-          this.Disconnect();
-        }
-        this.disposedValue = true;
-      }
-    }
-
-    public override void Dispose() {
-      this.Dispose(true);
-      GC.SuppressFinalize(this);
-    }
-    #endregion
   }
 }

Bot-Utils/Moduls/Overtaker.cs

@@ -2,7 +2,7 @@
 using System.Collections.Generic;
 
 namespace BlubbFish.Utils.IoT.Bots.Moduls {
-  public abstract class Overtaker<T> : AModul<T>, IDisposable {
+  public abstract class Overtaker<T> : AModul<T> {
     protected readonly Dictionary<String, Dictionary<String, String>> events = new Dictionary<String, Dictionary<String, String>>();
 
     #region Constructor
@@ -62,22 +62,7 @@ namespace BlubbFish.Utils.IoT.Bots.Moduls {
     #region AModul
     public override void Interconnect(Dictionary<String, AModul<T>> moduls) { }
     protected override void UpdateConfig() => this.ParseIni();
-    #endregion
-
-    #region IDisposable Support
-    private Boolean disposedValue = false;
-
-    protected virtual void Dispose(Boolean disposing) {
-      if (!this.disposedValue) {
-        if (disposing) {
-        }
-        this.disposedValue = true;
-      }
-    }
-
     public override void Dispose() {
-      this.Dispose(true);
-      GC.SuppressFinalize(this);
     }
     #endregion 
   }

Bot-Utils/Moduls/Statuspolling.cs

@@ -3,7 +3,7 @@ using System.Collections.Generic;
 using BlubbFish.Utils.IoT.Bots.Interfaces;
 
 namespace BlubbFish.Utils.IoT.Bots.Moduls {
-  public abstract class Statuspolling<T> : AModul<T>, IDisposable, IForceLoad {
+  public abstract class Statuspolling<T> : AModul<T>, IForceLoad {
 
     #region Constructor
     public Statuspolling(T lib, InIReader settings) : base(lib, settings) { }
@@ -31,22 +31,7 @@ namespace BlubbFish.Utils.IoT.Bots.Moduls {
       }
     }
     protected override void UpdateConfig() { }
-    #endregion
-
-    #region IDisposable Support
-    private Boolean disposedValue = false;
-
-    protected virtual void Dispose(Boolean disposing) {
-      if (!this.disposedValue) {
-        if (disposing) {
-        }
-        this.disposedValue = true;
-      }
-    }
-
     public override void Dispose() {
-      this.Dispose(true);
-      GC.SuppressFinalize(this);
     }
     #endregion
   }

Bot-Utils/MultiSourceBot.cs

@@ -1,8 +1,6 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
+
 using BlubbFish.Utils.IoT.Connector;
 
 namespace BlubbFish.Utils.IoT.Bots {
@@ -10,7 +8,7 @@ namespace BlubbFish.Utils.IoT.Bots {
     protected Dictionary<String, ABackend> sources;
     protected Dictionary<String, String> settings;
 
-    protected MultiSourceBot(Dictionary<String, ABackend> sources, Dictionary<String, String> settings) {
+    protected MultiSourceBot(String[] args, Boolean fileLogging, String configSearchPath, Dictionary<String, ABackend> sources, Dictionary<String, String> settings) : base(args, fileLogging, configSearchPath) {
       this.sources = sources;
       this.settings = settings;
     }

Changelog.md

@@ -1,5 +1,27 @@
 # Changelog
 
+## 1.2.6 - 2022-01-25 - Makeing Logging easyier
+### New Features
+* Construct the Programm logger only if enabled
+* Set Searchpath by default for a Bot
+* Add an option that allows to debug logging (by default on)
+### Bugfixes
+### Changes
+* Deconstruct Programmlogger
+* Change all classes that extend ABot
+* Module messages also uses debug logging flag
+* Codingstyles
+
+## 1.2.5 - 2022-01-20 - Better linux handling
+### New Features
+* Add ProcessExit Handler in ABot
+* Add Output in ModulDispose
+### Bugfixes
+* Eleminate Hangs in Cronjob, when in startup phase it not blocks shutdown
+### Changes
+* Reweite ABot, remove Mono Code
+* Codingstyle
+
 ## 1.2.4 - 2022-01-18 - Config enabled module loading
 ### New Features
 * Modules can have an enabled=true|false in config, so that also enables or disables moduleloading.